fix(v2v-helper): drain CopyDisk progress goroutine before closing pipe - #2323
Conversation
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
CopyDisk closed the progress pipe via defer before its background progress-scanner goroutine had finished draining it, racing the goroutine and occasionally truncating the final read (e.g. the last 100% update). Wait for the goroutine before returning so progress logging always reflects the real completion state (#2139). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
91e4ea6 to
ef53f16
Compare
🚨 Security Vulnerability SummarySecurity posture degraded 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
🚨 Added VulnerabilitiesTrivy (Dependencies) - 3 AddedTarget: Target: Target: Only HIGH and CRITICAL severity vulnerabilities are tracked |
What this PR does / why we need it
CopyDisk closed the progress pipe via defer before its background progress-scanner goroutine had finished draining it, racing the goroutine and occasionally truncating the final read (e.g. the last 100% update). Wait for the goroutine before returning so progress logging always reflects the real completion state (#2139).
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #2139
Special notes for your reviewer
Testing done
please add testing details (logs, screenshots, etc.)