Skip to content

fix(v2v-helper): drain CopyDisk progress goroutine before closing pipe - #2323

Merged
OmkarDeshpande7 merged 1 commit into
mainfrom
private/main/ghi-2139
Aug 25, 2026
Merged

fix(v2v-helper): drain CopyDisk progress goroutine before closing pipe#2323
OmkarDeshpande7 merged 1 commit into
mainfrom
private/main/ghi-2139

Conversation

@spai-p9

@spai-p9 spai-p9 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it

CopyDisk closed the progress pipe via defer before its background progress-scanner goroutine had finished draining it, racing the goroutine and occasionally truncating the final read (e.g. the last 100% update). Wait for the goroutine before returning so progress logging always reflects the real completion state (#2139).

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #2139

Special notes for your reviewer

Testing done

please add testing details (logs, screenshots, etc.)

@github-actions

Copy link
Copy Markdown
Contributor

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric Count
Total Added 0
Total Fixed 0
Net Change 0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
92 92 0 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 29134c894d55e8571260619b87ca0ea4b68b84e8

@github-actions

Copy link
Copy Markdown
Contributor

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric Count
Total Added 0
Total Fixed 0
Net Change 0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
92 92 0 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 7cfa34ef69faceaefac1d947aeb711fdea9689cb

@spai-p9
spai-p9 requested a review from meghansh-pf9 August 21, 2026 06:04
Comment thread v2v-helper/nbd/nbdops.go

@OmkarDeshpande7 OmkarDeshpande7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OmkarDeshpande7
OmkarDeshpande7 enabled auto-merge (squash) August 25, 2026 06:17
CopyDisk closed the progress pipe via defer before its background
progress-scanner goroutine had finished draining it, racing the goroutine
and occasionally truncating the final read (e.g. the last 100% update).
Wait for the goroutine before returning so progress logging always
reflects the real completion state (#2139).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Security Vulnerability Summary

Security posture degraded

📊 Overall Changes

Metric Count
Total Added 3
Total Fixed 0
Net Change +3

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
95 92 3 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

🚨 Added Vulnerabilities

Trivy (Dependencies) - 3 Added

Target: vjailbreak-ai/requirements.txt
Package: chromadb 0.5.20
Vulnerability: CVE-2026-45830
Severity: HIGH
Title: chromadb: ChromaDB: Unauthorized data manipulation due to improper authorization validation

Target: vjailbreak-ai/requirements.txt
Package: chromadb 0.5.20
Vulnerability: CVE-2026-45831
Severity: HIGH
Title: ChromaDB: ChromaDB: Unauthorized cross-tenant actions due to improper authorization checks

Target: vjailbreak-ai/requirements.txt
Package: chromadb 0.5.20
Vulnerability: CVE-2026-45833
Severity: CRITICAL
Title: chromadb: ChromaDB: Arbitrary Code Execution via Code Injection


Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: e8bf3d43dcc8609678bffff2d1f9b7433d17ba2f

@OmkarDeshpande7
OmkarDeshpande7 merged commit 4b13a69 into main Aug 25, 2026
17 checks passed
@OmkarDeshpande7
OmkarDeshpande7 deleted the private/main/ghi-2139 branch August 25, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration events shows wrong (90% but its completed) for data copy on details page

2 participants