Skip to content

feat: add a last-newest review action #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mshddev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add a last-newest review action #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ key = "prefix+shift+o"
type = "plugin_action"
command = "annotate.last"
description = "review the agent's last reply"

[[keys.command]]
key = "prefix+ctrl+o"
type = "plugin_action"
command = "annotate.last-newest"
description = "review the agent's newest reply"
```

</details>
Expand Down Expand Up @@ -159,6 +165,7 @@ Full install. Works with Claude Code, Codex, pi, Copilot CLI, Droid, Oh My Pi, H
|---|---|
| `Ctrl+B O` | this folder, with a file tree |
| `Ctrl+B Shift+O` | the agent's recent replies |
| `Ctrl+B Ctrl+O` | the agent's newest reply, with no picker |
| Ctrl-click a `file://…md` link | that file |

**Send** (or `E`) makes the review the agent's next message. `q` closes.
Expand Down
8 changes: 5 additions & 3 deletions docs/windows-full-acceptance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,16 @@ requirements, not completed verification. Every box starts unchecked.
| `open` | Annotate: open here | `workspace`, `pane` |
| `open-link` | Annotate this file | `pane` |
| `last` | Annotate: agent's last message | `pane` |
| `last-newest` | Annotate: agent's newest message | `pane` |

- [ ] Require exactly three panes: `editor` (Annotate, popup, 88×24), `manager`
(Annotations, popup, 100×30), and one `doc` (Annotate, overlay). The `doc`
command must be exactly `["./bin/plannotator-tui.exe", "herdr", "pane"]`.
No shell, PowerShell, command-string interpolation, or fallback launcher may sit
between Herdr's pane process and the TUI.
- [ ] Keep `open` and `open-link` as direct argv ending in `herdr open`, and
`last` as direct argv ending in `herdr last`, all using
- [ ] Keep `open` and `open-link` as direct argv ending in `herdr open`,
`last` as direct argv ending in `herdr last`, and `last-newest` as direct argv
ending in `herdr last --newest`, all using
`./bin/plannotator-tui.exe`. Preserve the `markdown-file` link handler's title,
pattern, and `open-link` action. All actions, panes, the handler, and the build
must be effective on Windows; no inherited Unix gate may disable them.
Expand Down Expand Up @@ -131,7 +133,7 @@ does not establish that a real Herdr pane works.
then an absolute path with spaces and Unicode. Assert each intended document
renders. Verify delivery target variables supplied by the launcher survive
unchanged. Exercise `open`, `open-link` (including a percent-encoded `file://`
path), and `last` with controlled context/transcript fixtures. Record fixture
path), `last`, and `last-newest` with controlled context/transcript fixtures. Record fixture
evidence separately from real-agent integration.
- [ ] Open Full with inert review-folder `.env` fixtures that would change a
launcher process. Full must render the intended document without loading those
Expand Down
8 changes: 8 additions & 0 deletions herdr-plugin.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@ contexts = ["pane"]
platforms = ["macos", "linux"]
command = ["./bin/plannotator-tui.exe", "herdr", "last"]

[[actions]]
id = "last-newest"
title = "Annotate: agent's newest message"
description = "Review the focused agent's newest message in plannotator-tui, without choosing from a picker first."
contexts = ["pane"]
platforms = ["macos", "linux"]
command = ["./bin/plannotator-tui.exe", "herdr", "last", "--newest"]

# Ctrl-click on a file:// Markdown link. Anchored on the scheme so web links never match.
[[link_handlers]]
id = "markdown-file"
Expand Down
4 changes: 2 additions & 2 deletions scripts/smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ trap restore EXIT

echo "== fresh install: full"
install "$spec"
check "actions" "$(actions)" "capture,copy-archive,copy-context,last,manage,open,open-link"
check "actions" "$(actions)" "capture,copy-archive,copy-context,last,last-newest,manage,open,open-link"
check "action programs" "$(programs)" "./bin/herdr-annotate.exe,./bin/plannotator-tui.exe"
check "review binary matches pin" "$(tui_version)" "$(tui_pin)"
check "native binary matches pin" "$(native_version)" "$(native_pin)"
Expand Down Expand Up @@ -134,7 +134,7 @@ check "manager pane" "$(manager_renders)" "ok"

echo "== swap: lite -> full"
install "$spec"
check "actions" "$(actions)" "capture,copy-archive,copy-context,last,manage,open,open-link"
check "actions" "$(actions)" "capture,copy-archive,copy-context,last,last-newest,manage,open,open-link"
check "review binary" "$(tui_version)" "$(tui_pin)"
check "native binary" "$(native_version)" "$(native_pin)"

Expand Down