Skip to content

follow: release the source snapshot connection after the catalog read #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teknogeek0 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

follow: release the source snapshot connection after the catalog read #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e1772e
follow: release the source snapshot connection after the catalog read
teknogeek0 Jul 25, 2026
06a6ded
Trim the snapshot-close comment
teknogeek0 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/bin/pgcopydb/cli_clone_follow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,21 @@ cli_follow(int argc, char **argv)
exit(EXIT_CODE_SOURCE);
}

/*
* The snapshot connection is only needed for the catalog read above;
* nothing in the follow phase uses it. Close it now so a follow-only run
* doesn't hold it idle-in-transaction for the whole run. Gate on the live
* connection, not sourceSnapshot.state, which the catalog read leaves stale.
*/
if (copySpecs.sourceSnapshot.pgsql.connection != NULL)
{
if (!copydb_close_snapshot(&copySpecs))
{
/* errors have already been logged */
exit(EXIT_CODE_SOURCE);
}
}

if (!follow_main_loop(&copySpecs, &specs))
{
/* errors have already been logged */
Expand Down
Loading