Skip to content

refactor(mise): let mise enable Corepack, drop the brew entry - #103

Merged
pjungermann merged 1 commit into
mainfrom
pjungermann/mise-managed-corepack
Nov 2, 2026
Merged

pjungermann merged 1 commit into
mainfrom
pjungermann/mise-managed-corepack

Conversation

@pjungermann

Copy link
Copy Markdown
Owner

What changes

  • Set settings.node.corepack = true in dot_config/mise/config.toml so mise runs corepack enable itself after installing any Node version that ships Corepack.
  • Remove brew "corepack" from the Brewfile — the safety-net install added in fix: install corepack via Homebrew so step 8 can find it #92 is no longer needed.
  • Drop the standalone corepack enable call from bin/install-software.sh step 8. The shim is already live by the time this step runs, right after mise install.
  • Keep corepack install -g yarn@stable so Yarn remains eagerly provisioned; per-project pinning via packageManager is unchanged.

Why

mise's Node plugin natively supports the Corepack lifecycle hook, which fits the repo's AGENTS.md rule mise > brew > mas: migrate up when a mise plugin exists. One fewer brew formula, one fewer manual step in the install script, and the same end state.

Verification

Shellcheck clean on bin/install-software.sh. Full install-on-fresh-mac flow not re-run in this change; the behaviour is attested by mise's docs rather than observed here.

Ref: https://mise.jdx.dev/lang/node.html#corepack
Relates-to: #92

mise's node plugin exposes `settings.node.corepack`, which runs
`corepack enable` after installing any Node version that ships
Corepack. Turning it on means the shim is active immediately after
step 7 (`mise install`), so step 8's standalone `corepack enable`
and the Homebrew `corepack` safety net added in #92 are both
redundant.

Keeps `corepack install -g yarn@stable` so Yarn is still eagerly
provisioned; per-project pinning via packageManager is unchanged.

Ref: https://mise.jdx.dev/lang/node.html#corepack
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ BASH bash-exec 1 0 0 0.66s
✅ BASH shellcheck 1 0 0 0.72s
✅ COPYPASTE jscpd yes no no 0.91s
✅ REPOSITORY git_diff yes no no 0.01s
✅ SPELL cspell 3 0 0 2.3s

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@pjungermann
pjungermann marked this pull request as ready for review November 2, 2026 20:25
@pjungermann
pjungermann merged commit 941f351 into main Nov 2, 2026
3 checks passed
@pjungermann
pjungermann deleted the pjungermann/mise-managed-corepack branch November 2, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant