Repository navigation
refactor(mise): let mise enable Corepack, drop the brew entry - #103
Merged
Merged
Conversation
mise's node plugin exposes `settings.node.corepack`, which runs `corepack enable` after installing any Node version that ships Corepack. Turning it on means the shim is active immediately after step 7 (`mise install`), so step 8's standalone `corepack enable` and the Homebrew `corepack` safety net added in #92 are both redundant. Keeps `corepack install -g yarn@stable` so Yarn is still eagerly provisioned; per-project pinning via packageManager is unchanged. Ref: https://mise.jdx.dev/lang/node.html#corepack
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes
settings.node.corepack = trueindot_config/mise/config.tomlso mise runscorepack enableitself after installing any Node version that ships Corepack.brew "corepack"from theBrewfile— the safety-net install added in fix: install corepack via Homebrew so step 8 can find it #92 is no longer needed.corepack enablecall frombin/install-software.shstep 8. The shim is already live by the time this step runs, right aftermise install.corepack install -g yarn@stableso Yarn remains eagerly provisioned; per-project pinning viapackageManageris unchanged.Why
mise's Node plugin natively supports the Corepack lifecycle hook, which fits the repo's
AGENTS.mdrule mise > brew > mas: migrate up when a mise plugin exists. One fewer brew formula, one fewer manual step in the install script, and the same end state.Verification
Shellcheck clean on
bin/install-software.sh. Full install-on-fresh-mac flow not re-run in this change; the behaviour is attested by mise's docs rather than observed here.Ref: https://mise.jdx.dev/lang/node.html#corepack
Relates-to: #92