release: fleet observability Phase 2 — /admin/fleet panel + ingest route (#69) - #71
Merged
Merged
Conversation
…servability Phase 2) (#69) * feat(fleet): sofra /admin/fleet panel + bearer ingest route (fleet observability Phase 2) Adds the control-plane VIEW layer for fleet observability: each tenant backend (next slice) pushes a compact per-tenant snapshot to a bearer-authed ingest route, sofra stores it in its own DB, and /admin/fleet renders the fleet — device liveness, order-feed state, and missed-order counts, joined to the tenant registry for owner/tenant identity. - Prisma FleetSummary (per tenant, tenantSlug @unique — keyed not FK, like TenantBilling) + FleetDevice (unique [tenantSlug, deviceId]); handwritten migration 20260720013000_fleet_observability. - lib/fleet.ts: zod fleetPushSchema (non-PII, all fields bounded to the DB columns) + ingestFleetPush (one transaction: upsert summary, then reconcile the device roster — upsert reported, prune the rest, scoped to the tenant). - app/api/telemetry/fleet/route.ts: constant-time PRINTER_TELEMETRY_SECRET bearer (cloned from cron/retention), 503-when-unset, 401/400 before any write, never echoes the payload. Documented shared-secret trust model + per-tenant-binding follow-up for the backend push slice. - app/(control)/admin/fleet/page.tsx: requireAdmin, force-dynamic registry read, derives online/offline + stale-feed at the presentation layer (craft tokens). - i18n: fleet keys added to all 6 locales (parity) + nav.fleet. Why: fleet observability Phase 2 (asks #2 owner/tenant, #6 manage from admin panel). The backend FleetSummaryPushService (producer) is the follow-up slice; until it ships the panel shows the empty state. Deploy note (sofra §5.2): schema change — run the :migrate one-off on the box BEFORE rolling the app. Set PRINTER_TELEMETRY_SECRET (else the route 503s, inert). - 4 vitest cases for fleetPushSchema (coerce dates, defaults, reject bad input); typecheck + next build green (both routes compile) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * refactor(fleet): dedup+sort ingest devices, readonly props, extract ternaries, early-return (PR #69 review) Gemini + Sonar review on the Phase 2 panel: - ingestFleetPush dedups devices by deviceId + sorts deterministically, so a repeated id can't double-upsert and concurrent same-tenant pushes lock rows in the same order (no deadlock). - page.tsx: mark component props Readonly (S6759); extract the liveness/feed nested ternaries into helper functions (S3358); early-return when the registry is unavailable (skips the DB reads + removes the outer JSX ternary). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a printer fleet observability feature, allowing tenant backends to push compact, non-PII device telemetry and summaries to a central dashboard. This includes database schemas (FleetSummary and FleetDevice), an API endpoint (/api/telemetry/fleet) with bearer token authentication, an admin dashboard page (/admin/fleet), and multi-language localization support. Feedback on the changes suggests optimizing database queries on the admin fleet page by filtering fleetDevice and fleetSummary retrievals to only include active tenants from the registry, preventing unnecessary data loading as the system scales.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3 tasks
mahmutkaya
added a commit
that referenced
this pull request
Jul 20, 2026
…#71 follow-up) (#72) Filter fleetDevice/fleetSummary findMany by the registry's active tenant slugs so orphaned/decommissioned rows aren't loaded as the fleet grows. No-op at the current single-tenant scale; the deferred optimization from the #71 release review. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: fleet observability Phase 2 (sofra side)
Promotes the single unreleased
developcommit — the fleet observability control-plane view layer (#69) — to productionmain.Contents (1 commit):
feat(fleet): sofra /admin/fleet panel + bearer ingest route (#69)FleetSummary+FleetDevicemodels + handwritten migration20260720013000_fleet_observability(two new tables — additive).POST /api/telemetry/fleetbearer ingest route (503 untilPRINTER_TELEMETRY_SECRETset — inert)./admin/fleetadmin page (requireAdmin; shows registered tenants + their device roster; empty until the backend push is configured).Risk: low, additive. No changes to any existing surface; the new page is admin-only and shows the empty state until
PRINTER_TELEMETRY_SECRET+ the backendFleetPushconfig are set.Deploy steps (post-merge, manual — founder-run)
Merge builds
ghcr.io/piwas-21/sofra:migrate+:latest. Then on the staging box (/opt/rumi/deploy):docker pull ghcr.io/piwas-21/sofra:migratedocker run --rm --network deploy_rumi -e DATABASE_URL="postgresql://sofra:<pw>@postgres:5432/sofra" ghcr.io/piwas-21/sofra:migrate(=prisma migrate deploy)docker compose -f docker-compose.prod.yml up -d sofrahttps://sofrapiwas.com/admin/fleetrenders.🤖 Generated with Claude Code