Skip to content

fix: align v1 canonicalization with Go and reject duplicate keys - #27

Merged
luckyPipewrench merged 2 commits into
mainfrom
fix/v1-canonical-field-drift
Jun 1, 2026
Merged

luckyPipewrench merged 2 commits into
mainfrom
fix/v1-canonical-field-drift

Conversation

@luckyPipewrench

Copy link
Copy Markdown
Member

The v1 canonical field list was missing parent_action_id, the taint and contract blocks, severity, redaction, and shield, and it neither reordered nested object keys nor sorted free-form map keys. A receipt carrying any of those fields recomputed a different signing hash and failed verification here while passing in Go.

  • Mirror the full Go ActionRecord field set, order, and omitempty semantics; recurse into nested redaction/shield/taint objects; sort map keys (by_class) to match json.Marshal.
  • Reject duplicate object keys on the verify path (single receipts + JSONL chains); reject input nested beyond the shared depth cap so deep input is rejected, not crashed.
  • Regression tests: full field set, nested ordering, map sort, dup-key (incl. unicode-escaped), depth.

Backward compatible for receipts without the new fields; existing tests pass.

The v1 canonical field list was missing parent_action_id, the taint and
contract blocks, severity, redaction, and shield, and it neither reordered
nested object keys nor sorted free-form map keys. A receipt carrying any of
those fields recomputed a different signing hash and failed verification here
while passing in Go. Mirror the full Go ActionRecord field set, declaration
order, and omitempty semantics; recurse into nested redaction/shield/taint
objects; and sort map keys (by_class) to match json.Marshal.

Reject duplicate object keys on the verify path (last-wins parsing is a
smuggling vector that lets a first-occurrence display layer disagree with the
signed value), and reject input nested beyond the shared cross-language depth
cap so deeply nested input is rejected rather than crashing.

Add regression tests covering the full field set, nested ordering, map-key
sorting, duplicate-key rejection (including unicode-escaped keys), and depth.
@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@luckyPipewrench, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9a731c62-293c-4822-8379-52db004c2ec6

📥 Commits

Reviewing files that changed from the base of the PR and between ea1ee90 and 2fc73e5.

📒 Files selected for processing (4)
  • pipelock_verify/_canonical.py
  • pipelock_verify/_common.py
  • pipelock_verify/_verify.py
  • tests/test_field_drift.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v1-canonical-field-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@luckyPipewrench
luckyPipewrench merged commit 5ecd1ad into main Jun 1, 2026
14 checks passed
@luckyPipewrench
luckyPipewrench deleted the fix/v1-canonical-field-drift branch June 1, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant