Repository navigation
fix: align v1 canonicalization with Go and reject duplicate keys - #27
Conversation
The v1 canonical field list was missing parent_action_id, the taint and contract blocks, severity, redaction, and shield, and it neither reordered nested object keys nor sorted free-form map keys. A receipt carrying any of those fields recomputed a different signing hash and failed verification here while passing in Go. Mirror the full Go ActionRecord field set, declaration order, and omitempty semantics; recurse into nested redaction/shield/taint objects; and sort map keys (by_class) to match json.Marshal. Reject duplicate object keys on the verify path (last-wins parsing is a smuggling vector that lets a first-occurrence display layer disagree with the signed value), and reject input nested beyond the shared cross-language depth cap so deeply nested input is rejected rather than crashing. Add regression tests covering the full field set, nested ordering, map-key sorting, duplicate-key rejection (including unicode-escaped keys), and depth.
|
Warning Review limit reached
More reviews will be available in 49 minutes and 7 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The v1 canonical field list was missing
parent_action_id, the taint and contract blocks,severity,redaction, andshield, and it neither reordered nested object keys nor sorted free-form map keys. A receipt carrying any of those fields recomputed a different signing hash and failed verification here while passing in Go.ActionRecordfield set, order, and omitempty semantics; recurse into nested redaction/shield/taint objects; sort map keys (by_class) to matchjson.Marshal.Backward compatible for receipts without the new fields; existing tests pass.