Skip to content

feat: Scorecard + CodeQL workflows, 6-badge README, RFC 3339 nanosecond fix - #2

Merged
luckyPipewrench merged 1 commit into
mainfrom
pimp-the-repo
Apr 19, 2026
Merged

luckyPipewrench merged 1 commit into
mainfrom
pimp-the-repo

Conversation

@luckyPipewrench

@luckyPipewrench luckyPipewrench commented Apr 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Single signed commit. No logo, no committed social-preview file (uploaded via Settings UI).

Changes

  1. Correctness fix for Python 3.9 / 3.10 — datetime.fromisoformat on those versions tops out at microsecond precision (6 fractional digits). Go emits time.RFC3339Nano timestamps with up to 9 fractional digits, and the conformance fixture exercises that shape. _is_valid_rfc3339 now truncates fractional seconds to 6 digits before parsing so Go-emitted timestamps verify on every supported Python version. Shape validation (regex) still covers 1-9 digits; semantic validation unchanged.
  2. OpenSSF Scorecard workflow — weekly + on push to main, publishes SARIF to code-scanning.
  3. CodeQL workflow (Python) — security-and-quality query set on every PR, weekly on main.
  4. README badge strip refresh — 6 badges: PyPI, Python, CI, CodeQL, Scorecard, License. Nav link row retained.

What's intentionally NOT in this PR

  • No logo (separate discussion; avoid reusing the flagship Pipelock logo on a supporting library).
  • No committed assets/social-preview.png (uploaded via repo Settings, committing the PNG is dead weight).
  • No Downloads badge (low signal on a brand-new package).
  • No scanned-by-pipelock badge (trimmed per the scope-tight review).

Test plan

  • pytest — 62 passed
  • ruff check — clean
  • ruff format --check — clean
  • mypy pipelock_verify — strict, clean
  • Manual RFC 3339 parse check against plain Z, 3/9 digit fractionals, +00:00, -07:00, bad hour, non-date string

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

…nd fix

Three tightly scoped changes:

1. Correctness fix for Python 3.9 / 3.10.
   datetime.fromisoformat on 3.9/3.10 tops out at microsecond precision
   (6 fractional digits). Go emits time.RFC3339Nano with up to 9
   fractional digits, and our conformance fixture exercises that shape.
   _is_valid_rfc3339 now truncates fractional seconds to 6 digits
   before calling fromisoformat so Go-emitted timestamps verify on
   every supported Python version. The regex shape-check still covers
   1-9 digits; semantic validation (bad month, day 32, etc) is
   unchanged.

2. OpenSSF Scorecard workflow.
   Runs weekly and on every push to main, publishes results to
   code-scanning.

3. CodeQL workflow (Python).
   security-and-quality query set on every PR, weekly on main.

4. README badge strip refresh.
   Six badges: PyPI, Python, CI, CodeQL, Scorecard, License. Nav link
   row kept for scanability.
@luckyPipewrench luckyPipewrench changed the title feat: repo pimpery pass + logo + social preview + RFC 3339 nanosecond fix feat: Scorecard + CodeQL workflows, 6-badge README, RFC 3339 nanosecond fix Apr 19, 2026
@luckyPipewrench
luckyPipewrench merged commit 12fc9a9 into main Apr 19, 2026
11 checks passed
@luckyPipewrench
luckyPipewrench deleted the pimp-the-repo branch April 19, 2026 18:26
luckyPipewrench added a commit that referenced this pull request Apr 19, 2026
First patch release. Includes the RFC 3339 nanosecond timestamp fix
shipped in #2 that restores verification against Go-emitted receipts
on Python 3.9 and 3.10.

Tag v0.1.1 on merge to trigger the OIDC publish workflow.
@luckyPipewrench luckyPipewrench mentioned this pull request Apr 19, 2026
2 tasks done
luckyPipewrench added a commit that referenced this pull request Apr 19, 2026
First patch release. Includes the RFC 3339 nanosecond timestamp fix
shipped in #2 that restores verification against Go-emitted receipts
on Python 3.9 and 3.10.

Tag v0.1.1 on merge to trigger the OIDC publish workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants