Problem
test_agent_validate_behaviors_json in packages/cli/tests/test_cli_agent_automation_smoke.py asserts only body.get("success") is True. Its fixture is a move_card behavior with destinationPhaseId: "2" on a pipe with no phases, so the validator returns valid: false with one problem:
{'success': True, 'valid': False, 'problems': ['Behavior [0] "x", action [0] (move_card): destinationPhaseId "2" not found in pipe phases.'], 'warnings': [], 'message': 'Found 1 problem(s) in behaviors.'}
The test passes whether the validator reports that problem or not. A regression that drops the phase check does not fail it.
Proposal
Assert the result the fixture produces: valid is false, and problems names destinationPhaseId "2". The alternative is to give the fixture a phase 2 and assert valid is true, which mirrors the MCP twin of this test.
Context
The assert dates from 917d0fa. The review of #701 raised it, and it is out of scope there.
Problem
test_agent_validate_behaviors_jsoninpackages/cli/tests/test_cli_agent_automation_smoke.pyasserts onlybody.get("success") is True. Its fixture is amove_cardbehavior withdestinationPhaseId: "2"on a pipe with no phases, so the validator returnsvalid: falsewith one problem:The test passes whether the validator reports that problem or not. A regression that drops the phase check does not fail it.
Proposal
Assert the result the fixture produces:
validis false, andproblemsnamesdestinationPhaseId "2". The alternative is to give the fixture a phase2and assertvalidis true, which mirrors the MCP twin of this test.Context
The assert dates from 917d0fa. The review of #701 raised it, and it is out of scope there.