cheap way to give access to ^W, etc; closes #29, #25#30
Open
doriantaylor wants to merge 5 commits intopiotrmurach:masterfrom
Open
cheap way to give access to ^W, etc; closes #29, #25#30doriantaylor wants to merge 5 commits intopiotrmurach:masterfrom
doriantaylor wants to merge 5 commits intopiotrmurach:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
This is a trivial change that affords
^Wetc; closing #29 and #25.Why are we doing this?
Users expect common shell key bindings to be available.
Benefits
The ability to set said key bindings.
Drawbacks
Don't know. There is a tradeoff between passing
lineinto the key event rather thanline.to_sand the downstream expectation that nothing is going to change that value. I had to change the unit tests to pass, but at a glance that seems more reasonable. I probably would have designed it so the return value oftriggeris captured as a replacement for the line, but introducing that now would probably break more stuff downstream.