Fix Multiline Prompt Line Wrapping#28
Open
ColonelPanics wants to merge 1 commit intopiotrmurach:masterfrom
Open
Fix Multiline Prompt Line Wrapping#28ColonelPanics wants to merge 1 commit intopiotrmurach:masterfrom
ColonelPanics wants to merge 1 commit intopiotrmurach:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR addresses an issue with multiline prompts whereby longer previous lines cause the width calculation to be incorrect, leading to strange behaviour in the terminal session. It looks like this bug was introduced in this PR.
This is the current behaviour:
PreviousBehaviour.mov
With this change, the behaviour is as follows:
New.Behaviour.mov
Why are we doing this?
This change is being made because the prompt moving up the display is not desirable behaviour.
Benefits
One less bug!
Drawbacks
If any existing code was dependent on this sort of behaviour (I sure hope not!) then it will no longer work.
Requirements
masterbranch?