Add SILK Burg LPC analysis#159
Merged
Merged
Conversation
Co-authored-by: François Allais <francois.allais@hotmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 88.57% 88.50% -0.07%
==========================================
Files 38 39 +1
Lines 8252 8341 +89
==========================================
+ Hits 7309 7382 +73
- Misses 712 725 +13
- Partials 231 234 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FrantaBOT
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds
burgModifiedFLP— LPC coefficient estimation via Burg's method, stacked over multiple subframes and capped at a max prediction gain (minInvGain). Wraps it infindLPC, which converts the result straight to NLSFs viaa2nlsfFLP. the NLSF-interpolation search (picking the best interpolation index between the previous frame's NLSFs and this one) is deferred — the interpolation index stays fixed at 4 (no interpolation) for nowported from
burg_modified_FLP.ccaught one real bug while reviewing this locally, worth mentioning since it's not visible in the diff: I'd hand-copied the file instead of extracting it cleanly and introduced a few divergences from the reference (a dropped accumulation, a missing multiply, and a whole per-subframe update loop that went missing) —
TestBurgModifiedFLPRecoversARcaught it immediately once I actually ran the tests. re-extracted the file straight from François's branch instead of retyping, so what's here now is his original, unmodifiedReference issue
part of the SILK encoder series (#158)