Apply min and max bitrate options to loss based BWE#433
Open
zaki699-blip wants to merge 1 commit into
Open
Conversation
SendSideBWEMinBitrate and SendSideBWEMaxBitrate were only applied to the delay-based controller. The loss-based controller hardcoded its bounds at 100 kbps / 100 Mbps, and since the combined estimate is min(delayEstimate, lossEstimate), sustained loss pinned the reported estimate at exactly 100 kbps regardless of the configured minimum: the loss controller only recovers at 1.05x per 200 ms and only while loss stays under 2 percent. Pass the configured min and max through to newLossBasedBWE so both controllers honor the same bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SendSideBWEMinBitrateandSendSideBWEMaxBitrateare currently only applied to the delay-based controller (send_side_bwe.gopassessend.minBitrate/send.maxBitrateintonewDelayController, butnewLossBasedBWEreceives only the initial bitrate and hardcodes its bounds at 100 kbps / 100 Mbps).Because the final estimate is effectively
min(delayEstimate, lossEstimate)(getEstimatedoese.bitrate = min(wantedRate, e.bitrate)), the hardcoded loss floor overrides the configured minimum in practice: under sustained loss the loss controller decays to exactly 100_000 bps and stays there, since it only recovers at 1.05× per 200 ms and only while measured loss stays below 2%.We hit this in production with a media server distributing a high-bitrate live stream: every peer on a constrained link reported exactly 100 kbps despite
SendSideBWEMinBitrate(500_000), making the estimates unusable for downstream decisions.Change
Pass the configured min/max through to
newLossBasedBWEso both controllers honor the same bounds. Two lines of plumbing plus regression tests:No public API changes.