Repository navigation
fix(shared): compare peer version minors and patch floors numerically - #1297
deepanshupal wants to merge 6 commits into
Conversation
|
@deepanshupal is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: c781f1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. Walkthrough
ChangesPeer dependency version comparison
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The peer-version comparison is corrected for the inspected Expo requirement, with focused boundary tests and a matching changeset. No introduced merge-blocking issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
What changed
semverLitecompares minor strings lexically for caret ranges and doesn't enforce the patch floor for caret/tilde ranges. For example:semverLite("^7.2.0", "7.10.0")returns false, despite the installed minor being newer.semverLite("^7.10.0", "7.2.0")returns true, despite the installed minor being older.semverLite("^7.2.5", "7.2.4")and the equivalent tilde range return true below the required patch.This helper is used by the React, Solid, Vue and Expo peer dependency checks. The fix compares numeric minor/patch values, adds 11 regression/boundary cases and a patch changeset for
@uploadthing/shared.The existing major-version and short-version behavior is preserved. This is a focused correction to the lightweight helper, not a replacement with a full semver implementation.
Verification
@uploadthing/sharedtypecheck and lint pass, after building its workspace MIME dependency.git diff --checkpasses.I did not run the full workspace test suite or workspace-wide typecheck.
Summary by CodeRabbit