Use schema decoding for Effect parsing paths#2775
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.t3code/vcs.jsonwithSchema.fromJsonStringand returnOptionfor missing/invalid config paths instead ofJSON.parse/null.Option.Why
These are small Effect idiom cleanups that make parsing paths more schema-driven, reduce nullable control flow, and keep timeout policy expressed as an
effect/Duration.UI Changes
Not applicable.
Checklist
Note
Use schema-based decoding for Windows process JSON and VCS project config parsing
parseWindowsProcessRowswithSchema-based decoding; records that fail validation are discarded rather than passed throughnormalizeWindowsProcessRownow strictly requires validpid,ppid, and a non-empty command, returningOption.nonefor invalid rowsparseWindowsProcessRowsis now exported and handles both array and single-object JSON responsesVcsProjectConfigparsing switches to schema-based decoding so invalid or malformed JSON deterministically returns'auto'instead of throwingMacroscope summarized cb6fa9c.