Fix Linux desktop bootstrap fd handling#1446
Open
smalitobules wants to merge 1 commit intopingdotgg:mainfrom
Open
Fix Linux desktop bootstrap fd handling#1446smalitobules wants to merge 1 commit intopingdotgg:mainfrom
smalitobules wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/self/fd/*ECONNRESETerrorsVerification
Notes
apps/server/src/main.test.tsis still blocked locally by a missingnode-ptynative binary in this environment, separate from this fix.Note
Medium Risk
Touches desktop↔server bootstrap IPC and file descriptor handling; regressions could prevent the desktop backend from starting on Linux or cause silent startup failures.
Overview
Improves robustness of the desktop backend bootstrap handshake.
On the desktop app, bootstrap envelope writing to the backend pipe is wrapped in a type guard and now attaches an
errorlistener before writing, avoiding unhandled stream errors and failing fast when the bootstrap pipe isn’t writable.On the server, bootstrap fd reading is refactored into
openBootstrapInputStreamand now falls back to reading directly from the inherited fd when duplicating/proc/self/fd/*fails withENXIO(Linux), with a new regression test covering this fallback path.Written by Cursor Bugbot for commit 8e632a5. This will update automatically on new commits. Configure here.
Note
Fix Linux desktop bootstrap fd handling for writable stream validation and ENXIO fallback
isWritableBootstrapStreamtype guard in main.ts to validate write, end, and once methods before writing;startBackendnow kills the child with SIGTERM and schedules a restart if the check fails.writeBackendBootstrapEnvelopehelper that attaches a one-time error listener and writes the JSON envelope, replacing inline logic instartBackend.openBootstrapInputStreamin bootstrap.ts that falls back to reading from the inherited fd directly when fd duplication fails with ENXIO, instead of throwing aBootstrapError.Macroscope summarized 8e632a5.