Skip to content

fix(android): measure markdown text in the span order its view draws it #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Nov 9, 2026
Merged

fix(android): measure markdown text in the span order its view draws it #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...riched-markdown/android/src/main/java/com/swmansion/enriched/markdown/MeasurementStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ import com.swmansion.enriched.markdown.utils.common.parseLinkPillContent
import com.swmansion.enriched.markdown.utils.common.parseLinkRecognition
import com.swmansion.enriched.markdown.utils.text.extensions.replaceMathSpansWithPlaceholders
import com.swmansion.enriched.markdown.utils.text.span.prepareWidthAwareSpans
import com.swmansion.enriched.markdown.utils.text.view.inViewSpanOrder
import java.util.concurrent.ConcurrentHashMap
import kotlin.math.ceil

Expand Down Expand Up @@ -755,7 +756,7 @@ object MeasurementStore {
): StaticLayout {
val builder =
StaticLayout.Builder
.obtain(content, 0, content.length, paint, widthPx)
.obtain(inViewSpanOrder(content), 0, content.length, paint, widthPx)
.setIncludePad(false)
.setLineSpacing(0f, 1f)

Expand Down
3 changes: 2 additions & 1 deletion ...n/android/src/main/java/com/swmansion/enriched/markdown/segments/SegmentHeightMeasurer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import com.swmansion.enriched.markdown.styles.StyleConfig
import com.swmansion.enriched.markdown.utils.common.BoundsForWidthUtils
import com.swmansion.enriched.markdown.utils.text.extensions.replaceMathSpansWithPlaceholders
import com.swmansion.enriched.markdown.utils.text.span.prepareWidthAwareSpans
import com.swmansion.enriched.markdown.utils.text.view.inViewSpanOrder
import kotlin.math.ceil

/** A stack's height and, for the root stack, the widest text line (px). */
Expand Down Expand Up @@ -219,7 +220,7 @@ object SegmentHeightMeasurer {
}
prepareWidthAwareSpans(text, widthPx)
return StaticLayout.Builder
.obtain(text, 0, text.length, paint, widthPx)
.obtain(inViewSpanOrder(text), 0, text.length, paint, widthPx)
.setIncludePad(false)
.setLineSpacing(0f, 1f)
.apply {
Expand Down
8 changes: 8 additions & 0 deletions ...wn/android/src/main/java/com/swmansion/enriched/markdown/utils/text/view/TextViewSetup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ private object NoCopySpannableFactory : Spannable.Factory() {
}
}

/**
* [text] as the markdown text view lays it out. Build every StaticLayout that sizes such
* a view from this: span order decides which LineHeightSpan wins on a shared line, so a
* layout over the bare builder can measure lines shorter than the view draws them.
*/
internal fun inViewSpanOrder(text: CharSequence): CharSequence =
if (text is SpannableStringBuilder) InsertionOrderedSpannable(text) else text

/**
* Hides that [buffer] is a `SpannableStringBuilder`. Layout reads a builder's paragraph
* spans in position order rather than insertion order, which paints nested list margins
Expand Down
Loading