Skip to content

Optimize logs #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3AceShowHand merged 4 commits into from
Jun 22, 2026
Merged

Optimize logs #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b2605f
idempotent is false still keep order by the mute
3AceShowHand Jun 17, 2026
95bf86e
Merge branch 'v1.41.2-pingcap' of https://github.com/pingcap/sarama i…
3AceShowHand Jun 17, 2026
aee3302
Merge branch 'v1.41.2-pingcap' of https://github.com/pingcap/sarama i…
3AceShowHand Jun 18, 2026
a69917e
remove some useless logs
3AceShowHand Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion async_producer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,6 @@ func (bp *brokerProducer) run() {
}

if bp.accumulatingBatch.wouldOverflow(msg) {
DebugLogger.Printf("producer/broker/%d maximum request accumulated, waiting for space\n", bp.broker.ID())
if err := bp.waitForSpace(msg, false); err != nil {
bp.parent.retryMessage(msg, err)
continue
Expand Down
2 changes: 0 additions & 2 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,12 +1103,10 @@ func (client *client) tryRefreshMetadata(topics []string, attemptsRemaining int,
return err
}
// else remove that broker and try again
Logger.Printf("client/metadata got error from broker %d while fetching metadata: %v\n", broker.ID(), err)
_ = broker.Close()
client.deregisterBroker(broker)
} else {
// some other error, remove that broker and try again
Logger.Printf("client/metadata got error from broker %d while fetching metadata: %v\n", broker.ID(), err)
brokerErrors = append(brokerErrors, err)
_ = broker.Close()
client.deregisterBroker(broker)
Expand Down
Loading