*: deprecate and remove telemetry#22961
Conversation
lilin90
added
translation/doing
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation across several files (pd-configuration-file.md, system-variables.md, and tidb-configuration-file.md) to reflect the deprecation of the telemetry configuration items and system variables starting from version v8.5.7. The review comments suggest improvements to align with the style guide, specifically recommending the use of past tense for historical version behaviors, clarifying version ranges, and removing redundant words like 'again' to avoid unnecessary repetition.
There was a problem hiding this comment.
Pull request overview
This PR updates TiDB documentation to reflect telemetry deprecation/removal behavior around v8.5.7 for related system variables and configuration items.
Changes:
- Adds v8.5.7 removal/deprecation notes for TiDB telemetry configuration and system variable docs.
- Revises the PD Dashboard
enable-telemetrysection to include patch-version behavior history. - Keeps the affected documentation focused on telemetry-related controls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tidb-configuration-file.md |
Adds a v8.5.7 deprecation/removal warning for TiDB enable-telemetry. |
system-variables.md |
Adds a v8.5.7 deprecation/removal warning for tidb_enable_telemetry. |
pd-configuration-file.md |
Updates PD Dashboard enable-telemetry warning and description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ti-chi-bot
Bot
added
size/S
Adjust telemetry lifecycle wording to match actual releases: expand the removed range from v8.1.0–v8.5.1 to v8.1.0–v8.5.2, and clarify the reintroduced period as v8.5.3–v8.5.6 (telemetry only logs locally). Also reaffirm that telemetry is removed again starting v8.5.7 and add a brief control description to the PD config. Affected files: pd-configuration-file.md, system-variables.md, telemetry.md, tidb-configuration-file.md.
|
/hold |
ti-chi-bot
Bot
added
the
do-not-merge/hold
lilin90
added
the
for-release
What is changed, added or deleted? (Required)
Deprecate and remove telemetry related system variable and config items.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?