Skip to content

Add note for setting TiDB configuration parameter during cluster upgr…#2431

Open
Benjamin2037 wants to merge 3 commits into
pingcap:masterfrom
Benjamin2037:server-version-note
Open

Add note for setting TiDB configuration parameter during cluster upgr…#2431
Benjamin2037 wants to merge 3 commits into
pingcap:masterfrom
Benjamin2037:server-version-note

Conversation

@Benjamin2037
Copy link
Copy Markdown

@Benjamin2037 Benjamin2037 commented Jul 31, 2023 •
edited
Loading

…ade.

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@ti-chi-bot ti-chi-bot Bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 31, 2023
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
ran-huang
ran-huang reviewed Jul 31, 2023
View reviewed changes
Comment thread zh/upgrade-tidb-operator.md Outdated
@ran-huang ran-huang requested a review from csuzhangxc July 31, 2023 12:46
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Jul 31, 2023
@ran-huang ran-huang self-assigned this Jul 31, 2023
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jul 31, 2023
ran-huang
ran-huang reviewed Jul 31, 2023
View reviewed changes
Comment thread zh/upgrade-tidb-operator.md
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请确认下适用哪些版本

Copy link
Copy Markdown
Author

@Benjamin2037 Benjamin2037 Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个版本对应 tidb 的版本不太清楚所以没填写，应该是一个怎样的对应关系呢？

Copy link
Copy Markdown
Contributor

@ran-huang ran-huang Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csuzhangxc 可以帮忙看下吗

Copy link
Copy Markdown
Member

@csuzhangxc csuzhangxc Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 Operator 这边这个参数没有特别，不用关心 Operator 的版本。 在哪些 TiDB 版本下需要关心这个参数？

Copy link
Copy Markdown
Author

@Benjamin2037 Benjamin2037 Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个影响的 TiDB 版本在 v3.10.0

@ran-huang ran-huang mentioned this pull request Aug 2, 2023
Merged
17 tasks
This was referenced Aug 2, 2023
Merged
Merged
Merged
Merged
@Benjamin2037 @ran-huang
Update zh/upgrade-tidb-operator.md
74aaca0 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang mentioned this pull request Aug 8, 2023
Merged
17 tasks
This was referenced Aug 14, 2023
Merged
Merged
Merged
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Apr 17, 2025

/bot-review

github-actions[bot]
github-actions Bot reviewed Apr 17, 2025
View reviewed changes
Comment thread zh/upgrade-tidb-operator.md

2. 弃用 Pod `ValidatingWebhook` 和 `MutatingWebhook`。如果使用 v1.2 及更早版本的 TiDB Operator 在集群部署了 Webhook，并启用了 Pod `ValidatingWebhook` 和 `MutatingWebhook`，升级 TiDB Operator 到 v1.3.0-beta.1 及之后版本，Pod `ValidatingWebhook` 和 `MutatingWebhook` 被删除，但这不会对 TiDB 集群管理产生影响，也不会影响正在运行的 TiDB 集群。

3. TiDB 节点的配置参数 [`server-version`](https://docs.pingcap.com/zh/tidb/stable/tidb-configuration-file#server-version) 会被 TiDB 节点用于验证当前 TiDB 的版本。因此在进行 TiDB 集群升级前，请将 `server-version` 的值设置为空或者当前 TiDB 真实的版本值，避免出现非预期行为。
Copy link
Copy Markdown

@github-actions github-actions Bot Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该说明过于简略，建议补充说明为何需要设置 server-version 以及不设置可能导致的具体问题，使读者更清楚其重要性。

Suggested change
3. TiDB 节点的配置参数 [`server-version`](https://docs.pingcap.com/zh/tidb/stable/tidb-configuration-file#server-version) 会被 TiDB 节点用于验证当前 TiDB 的版本。因此在进行 TiDB 集群升级前，请将 `server-version` 的值设置为空或者当前 TiDB 真实的版本值，避免出现非预期行为。
3. TiDB 节点的配置参数 [`server-version`](https://docs.pingcap.com/zh/tidb/stable/tidb-configuration-file#server-version) 会被 TiDB 节点用于验证当前 TiDB 的版本。在进行 TiDB 集群升级前，请将 `server-version` 的值设置为空或者当前 TiDB 真实的版本值。如果该参数值与实际版本不符，可能导致升级过程中出现版本校验失败等非预期行为。

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2025

✅ AI review completed, 1 comments generated.

@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Nov 28, 2025

Please update the base branch for this PR from master to release-1.x, as release-1.x is now the active development branch for TiDB Operator v1.x documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

+1 more reviewer

@ran-huang ran-huang ran-huang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Benjamin2037 @CLAassistant @qiancai @Oreoxmt @csuzhangxc @ran-huang