Skip to content

Update monitor-a-tidb-cluster.md#1953

Open
lilyjazz wants to merge 4 commits into
pingcap:masterfrom
lilyjazz:patch-1
Open

Update monitor-a-tidb-cluster.md#1953
lilyjazz wants to merge 4 commits into
pingcap:masterfrom
lilyjazz:patch-1

Conversation

@lilyjazz
Copy link
Copy Markdown
Member

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 31, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 31, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ran-huang
❌ lilyjazz
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot requested a review from ran-huang July 31, 2022 07:09
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2022
- 组件面板:

也可以设置 `spec.grafana.service.type` 为 `NodePort` 或者 `LoadBalancer`,通过 `NodePort` 或者 `LoadBalancer` 查看监控面板。
- Data TransferBinlog、Lightning、TiCDC
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 TransferBinlog 是写错了吗,还是这个面板就叫这个名字?

Copy link
Copy Markdown
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2022
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Nov 17, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 17, 2022
@ran-huang ran-huang added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 17, 2022
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Nov 28, 2025

Please update the base branch for this PR from master to release-1.x, as release-1.x is now the active development branch for TiDB Operator v1.x documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR’s assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants