fix(data): remove duplicate node_id 243113 — one bad row disables the whole trusted-agents feed#32
Closed
pstayets wants to merge 1 commit into
Closed
Conversation
…lot-mom) pilot-mom and pilot-director are published as two entries for ONE node: identical address 0:0000.0003.B5A9, identical node_id 243113, and the same "network planner" role. trustedagents.Load() rejects any list containing a duplicate node_id, so this single collision makes the ENTIRE 438-entry feed fail to load on every daemon. pilot-director is the redundant alias (the canonical name pilot-mom is what the docs, the app roster, the MCP package, and the homepage demo all use), so this removes the pilot-director entry. Node 243113 stays trusted via the pilot-mom entry; no node_id is invented. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0142ryqVGEmJN66VZtCC7wFD
Contributor
|
Superseded — the duplicate pilot-director row was already removed on main via #34. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pilot-momandpilot-directorare two entries intrusted-agents.jsonfor the same node — identicaladdress(0:0000.0003.B5A9) and identicalnode_id(243113). This removes the redundantpilot-directorentry (7-line deletion, nothing else). Node243113stays trusted through thepilot-momentry; no node_id is invented.How the collision got here
pilot-directorwas already in the list. Commit #31 ("Add pilot-mom, node 243113") addedpilot-momreusing that same node_id — introducing the duplicate. Since both entries point to the same node, #31 was effectively renaming the planner topilot-mom(the name the docs, the app roster, the MCP package, and the homepage demo all use) but left the oldpilot-directoralias behind. This PR completes #31 by removing that stale alias.Why it matters (not cosmetic)
Load()treats a duplicatenode_idas fatal for the entire list — itreturns before committing the parsed roster (data.go):So this single collision makes all 438 entries fail to load on every daemon, on every hourly refresh:
(observed live on a fresh v1.13.2 daemon joining the backbone)
Consequences today:
mainembeds this colliding list, soinit()hits the same error and setsbyNodeto an empty map — booting with zero trusted agents.TestEmbeddedListLoadsdoesn't catch this: it only assertsbyNode != nil, and the empty map is non-nil.Verification
git diff= 7 deleted lines, only thepilot-directorobject + the preceding comma. No reformatting; trailing-newline state preserved.pilot-mompresent with node_id243113; node243113still in the list.go test ./...→ok(full suite).Scope
Minimal data change only. The two entries are byte-identical on address and node_id, so they are provably the same node and removing the alias is the correct fix (there is no distinct second node to assign a new id to). A companion PR (loader hardening) makes
Load()degrade gracefully so a future duplicate can't drop the whole feed again.🤖 Generated with Claude Code
https://claude.ai/code/session_0142ryqVGEmJN66VZtCC7wFD