test(app-store): raise spawn lifecycle test timeout 3s -> 30s - #35
Merged
Conversation
TestSpawn_FastExitTriggersExitCode and TestSpawn_NonZeroExitPropagates wrap sup.spawn in a 3s context. Under parallel load the fake binary does not finish inside that budget, the context cancels, and spawn returns -1 instead of the real exit code — both tests fail at exactly 3.00s. They pass in ~0.3-0.5s when run in isolation. The assertion is on the exit code, not on latency, so the short deadline buys nothing and only encodes machine load into the result. Raise it to 30s. Test-only change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestSpawn_FastExitTriggersExitCodeandTestSpawn_NonZeroExitPropagatesfail under parallel load:Both fail at exactly 3.00s — the
context.WithTimeout(..., 3*time.Second)wrappingsup.spawn. Under load the fake binary doesn't finish inside that budget, the context cancels, andspawnreturns-1instead of the real exit code. In isolation they complete in ~0.3–0.5s and pass.Fix
Raise the deadline to 30s. The assertion is on the exit code, not on latency, so the tight deadline bought nothing and only encoded machine load into the result. Test-only.
Verification
go test -count=1 -run TestSpawn_ ./plugin/appstore/— all 6 passgo test -count=1 ./...— full suite green🤖 Generated with Claude Code