Skip to content

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX#215

Open
yhx-12243 wants to merge 2 commits intopi-base:mainfrom
yhx-12243:unneeded-internal-link
Open

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX#215
yhx-12243 wants to merge 2 commits intopi-base:mainfrom
yhx-12243:unneeded-internal-link

Conversation

@yhx-12243
Copy link
Contributor

Svelte has automatically internal link mechanism, so the manual implementation is not necessary and it is also wrong: When user click internal link just in LaTeX, it will goto undefined. So we simply delete it and it works well.

link.addEventListener('click', e => {
e.preventDefault()
goto((e.target as HTMLAnchorElement).href)
})

e.target is not necessary an <a>, it may deep inside a KaTeX node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant