Wip/bhahn/imx8mp proof reeding pd26#453
Conversation
Add the compile bootscripts *.scr.uimg to the list of files that are deployed by Yocto. Correct indentation for imx8mm. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
EFI boot has been disabled for this release due to it causing bugs for netboot with static IP addresses. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Remove the note that mentioned the change to fitImage boot and how to revert to legacyboot. FitImage boot is not new anymore and the legacyboot revert is not supported anymore, as this was already deprecated in the last release. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
The U-Boot Yocto recipe uses the github repo and https protocol. This change has already been done for the other platforms. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
We have not tested this bootscript for the release and therefore it is not officially supported. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Use the FIT image naming format instead of fitImage like it is done in the rest of the file. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Update list of overlays that are present in the fitImage. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Update list of overlays that are present in the fitImage. Also list the files in the same order as in the fitImage (alphabetically). Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
This feature is not supported in upcoming release. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Replace hardcoded imx8mp FPSC names with existing substitutions to get the renaming of the board. Also move the file to imx8mp-fpsc folder, as this is still specific to imx8mp-fpsc and only used there. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
PEB-WLBT is not supported in the upcoming release. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Remove usb-device chapter as this is not supported in the upcomming release. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Starting with 1618.2 version of Libra board, there is no miniPCIe anymore. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Add a warning, that peb-av-10 audio is broken and only HDMI audio is supported. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Suspend to RAM is not supported on Libra in upcoming release. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
lmsensors (contains fancontrol) are not present in the BSP, as the fan is controlled via kernel devicetree. Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
BHahn42618
requested review from
mschwan-phytec,
tremmet and
ymoog
as code owners
There was a problem hiding this comment.
My expectation is that the file will be made generic instead of moving it to imx8mp.
For 95 release, we have to move it back?!
Wouldn't it make more sense to keep it in the bsp directory?
There was a problem hiding this comment.
As half of the chapter consists of examples from the imx8mp devicetree and also the reset of the chapter was clearly designed with imx8mp-fpsc in mind and not imx95, I don't think, that it makes much sense to make it generic here. Instead I would create an extra chapter for imx95.
Also I don't know if the example with using SD interface pins as i2c works like this for imx95.
There was a problem hiding this comment.
After a closer look, I have to disagree. The chapter was clearly designed to be generic, you can see substitions already being present where appropriate.
Your changes destroy that concept. There are intentionally spelled out instead of using substitutions because they are toy examples.
Please leave this file as is in regards to this specific topic.
There was a problem hiding this comment.
I have to disagree with you here. This is not generic, as the chapter includes code example specific to one board: The old imx8mp Libra. As we did not change the code in the code examples, this happens to also fit for the new imx8mp Libra (except for the names), but the code examples do not fit the imx95. I would not put this in the imx95 manual like this, as the imx8mp code examples would probably cause confusion with readers.
There was a problem hiding this comment.
I see your point. Note that this is labelled as an 'example'. That means that a specific implementation of a broader concept is given.
So I suppose your opinion is that we should not have a generic file with an example, rather each fpsc based manual should copy the same boilerplate and implement their own "correct" code showcase?
I prefer the example, so we need another opinion. @mschwan-phytec do you want to add your opinion?
There was a problem hiding this comment.
I agree with @ymoog here. It's fine to present examples for a specific platform and that example doesn't have to be exact nor match for other platforms. After all, we want to deliver the concept behind FPSC and not explain platform-specific implementations.
We do the same in our security and RAUC manuals, so this style of teaching/manual is done elsewhere, too.
@BHahn42618 Please keep the fpsc-device-tree.rsti at its current location and just include it as is. No need to use more substitutions.
There was a problem hiding this comment.
After a closer look, I have to disagree. The chapter was clearly designed to be generic, you can see substitions already being present where appropriate.
Your changes destroy that concept. There are intentionally spelled out instead of using substitutions because they are toy examples.
Please leave this file as is in regards to this specific topic.
4 participants
Proofreading of imx8mp documentation for upcoming PD26.1.0. Mostly removing of unsupported features and some small fixes.