[node] Deprecate GLOBAL in favor of global

[sigv]

The GLOBAL variable should not be used in order to avoid DeprecationWarning: 'GLOBAL' is deprecated, use 'global'.

[sigv]

What's up with C code failing to build on this? 😕

[sigv]

This looks very much like the failure for 3306cad (that's the current master^). Is there some underlying bug with the project or the CI in particular?
I really do not see how C compiler can fail due to this change.

[FooBarWidget]

I think that CI failure is unrelated to your change. We've had various failures in the past because of Travis changing their environment. This looks like one of them.

Do you know from which Node.js version GLOBAL was deprecated in favor of global?

[sigv]

This commit was released in v6.0.0 according to the tags and this discussion due to the GLOBAL never having been actually documented.

[sigv]

As a side question, what is the SupportCentral label all about?

[FooBarWidget]

SupportCentral is a tool that we wrote and use internally for keeping track of which Github issues require a reply from us. It uses that label for keeping track. You can ignore the label.

[sigv]

What's the usual timeline for PRs for Passenger? When should I expect some response here?

[OnixGH]

@sigv There is no usual timeline, we try to look at them all but it depends on the urgency of a certain PR. One thing to note is that you shouldn't PR against master, but instead against stable.

[sigv]

@OnixGH Fair enough. I thought master was the development branch and, well, new changes should go into the development branch right away. Should I make a new PR for a stable branch?

[sigv]

The contributor's guide indeed says that changes should go to stable branches, so that's a mistake on my part; sorry! The question still stands.

[OnixGH]

@sigv not sure what answer you are looking for, but we don't have a timeline. Edit: Oh, maybe you meant about stable? Yes please!

[sigv]

@OnixGH Oh, sorry for the misunderstanding. Yeah I meant - the question still stands about branches. Will resubmit in that case.