Repository navigation
Build tally_hooks for PHP 8.6 NTS and ZTS of the newest release candidate - #12
Merged
Merged
Conversation
…date From 8.6, every official php image is thread safe and the -zts tags are gone (docker-library/php#1686), the last of them still 8.6.0RC2. So the build named after php:8.6-rc-cli was ZTS and the one named after php:8.6-rc-zts had the API version of RC2, and neither loaded into the NTS PHP 8.6 that setup-php and the distributions install: tally run reported every case as not measured. build-tally-hooks-in-php-image.sh builds PHP from the source the image ships when its PHP is not of the requested thread safety, and fails unless the build loads into a PHP of the thread safety its name says. Both 8.6 builds now come from php:8.6-rc-cli, and the cache is keyed by the digests of the images, so the next release candidate gets built instead of restoring the builds of an older one. Amp-Thread-ID: https://ampcode.com/threads/T-01a1f37b-1268-7739-9056-3fd3fa660669
The check ran only with 8.2 and 8.5, so the 8.6 builds of tally_hooks that no NTS PHP 8.6 loads were released unnoticed. Amp-Thread-ID: https://ampcode.com/threads/T-01a1f37b-1268-7739-9056-3fd3fa660669
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tally 1.0.1 ships
tally_hooksbuilds for PHP 8.6 that no NTS PHP 8.6 loads.tally runthen reports every case as not measured:tally_hooks-8.6.sotally_hooks-8.6-zts.soSince docker-library/php#1686, every official PHP 8.6 image is thread safe,
-cliincluded, and the-ztstags are gone. Their last image is still 8.6.0RC2. setup-php (php-version: 8.6) and the Ubuntu and Debian packages still install NTS, so the NTS build is still needed.build/build-tally-hooks-in-php-image.sh: when the image's PHP is not of the requested thread safety, it builds PHP from the source the image ships (docker-php-source,--disable-all). It then fails unless the.soloads into a PHP of the thread safety its file name says.php:8.6-rc-cli(RC7 today).Checked locally on x86_64:
8.6.0-dev), a phpstan-src benchmark is measured with the newtally_hooks-8.6.so. The same case is "not measured" with the hooks of 1.0.1.tally_hooks-8.6-zts.someasures it onphp:8.6-rc-cli.