Skip to content

Build tally_hooks for PHP 8.6 NTS and ZTS of the newest release candidate - #12

Merged
ondrejmirtes merged 2 commits into
1.xfrom
fix-php-8.6-tally-hooks
Nov 19, 2026
Merged

ondrejmirtes merged 2 commits into
1.xfrom
fix-php-8.6-tally-hooks

Conversation

@ondrejmirtes

Copy link
Copy Markdown
Member

Tally 1.0.1 ships tally_hooks builds for PHP 8.6 that no NTS PHP 8.6 loads. tally run then reports every case as not measured:

File Built for
tally_hooks-8.6.so API20261112, ZTS
tally_hooks-8.6-zts.so API20260924 (RC2), ZTS

Since docker-library/php#1686, every official PHP 8.6 image is thread safe, -cli included, and the -zts tags are gone. Their last image is still 8.6.0RC2. setup-php (php-version: 8.6) and the Ubuntu and Debian packages still install NTS, so the NTS build is still needed.

  • build/build-tally-hooks-in-php-image.sh: when the image's PHP is not of the requested thread safety, it builds PHP from the source the image ships (docker-php-source, --disable-all). It then fails unless the .so loads into a PHP of the thread safety its file name says.
  • Both 8.6 builds come from php:8.6-rc-cli (RC7 today).
  • The build cache is keyed by the digests of the images, so the next release candidate is built instead of restored from an older one.
  • The release tree check now also runs with PHP 8.6, NTS and ZTS, on both platforms.

Checked locally on x86_64:

  • All ten builds load into a PHP of their API and thread safety.
  • On setup-php's NTS PHP 8.6 (php-builder 8.6.0-dev), a phpstan-src benchmark is measured with the new tally_hooks-8.6.so. The same case is "not measured" with the hooks of 1.0.1.
  • The new tally_hooks-8.6-zts.so measures it on php:8.6-rc-cli.

…date

From 8.6, every official php image is thread safe and the -zts tags are
gone (docker-library/php#1686), the last of them still 8.6.0RC2. So the
build named after php:8.6-rc-cli was ZTS and the one named after
php:8.6-rc-zts had the API version of RC2, and neither loaded into the
NTS PHP 8.6 that setup-php and the distributions install: tally run
reported every case as not measured.

build-tally-hooks-in-php-image.sh builds PHP from the source the image
ships when its PHP is not of the requested thread safety, and fails
unless the build loads into a PHP of the thread safety its name says.
Both 8.6 builds now come from php:8.6-rc-cli, and the cache is keyed by
the digests of the images, so the next release candidate gets built
instead of restoring the builds of an older one.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f37b-1268-7739-9056-3fd3fa660669
The check ran only with 8.2 and 8.5, so the 8.6 builds of tally_hooks
that no NTS PHP 8.6 loads were released unnoticed.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f37b-1268-7739-9056-3fd3fa660669
@ondrejmirtes
ondrejmirtes merged commit edaa4f2 into 1.x Nov 19, 2026
34 checks passed
@ondrejmirtes
ondrejmirtes deleted the fix-php-8.6-tally-hooks branch November 19, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant