Skip to content

Conversation

@iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Jan 2, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 68.18182% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.04%. Comparing base (be9d879) to head (787b886).

Files with missing lines Patch % Lines
routing/page_loader_phpbb4.php 0.00% 13 Missing ⚠️
routing/page_loader.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
- Coverage     60.20%   60.04%   -0.16%     
- Complexity      214      224      +10     
============================================
  Files            15       18       +3     
  Lines           789      816      +27     
============================================
+ Hits            475      490      +15     
- Misses          314      326      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iMattPro iMattPro marked this pull request as draft January 3, 2026 15:39
@iMattPro iMattPro marked this pull request as ready for review January 13, 2026 02:00
@iMattPro iMattPro requested a review from Copilot January 13, 2026 02:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds compatibility for Symfony 7 and phpBB 4 by refactoring the page loader routing system. The implementation uses reflection to detect the Symfony version at runtime and delegates to version-specific adapters, ensuring the extension works across Symfony 3-7 and phpBB 3-4.

Changes:

  • Extracted core routing logic into a reusable page_loader_core class
  • Created version-specific adapters (page_loader_phpbb3 and page_loader_phpbb4) with appropriate type hints for their respective PHP/Symfony versions
  • Implemented runtime version detection in page_loader.php using reflection to determine which adapter to use

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
routing/page_loader_core.php New file containing extracted core logic for loading routes from the database
routing/page_loader_phpbb3.php New adapter for phpBB 3 / Symfony 3-6 with legacy-compatible type hints
routing/page_loader_phpbb4.php New adapter for phpBB 4 / Symfony 7 with strict type declarations and modern PHP syntax
routing/page_loader.php Refactored to use reflection-based version detection and delegate to appropriate adapter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants