-
Notifications
You must be signed in to change notification settings - Fork 25
Symfony 7 and phpBB 4 compatibility #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b2c11e3 to
704fb46
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
============================================
- Coverage 60.20% 60.04% -0.16%
- Complexity 214 224 +10
============================================
Files 15 18 +3
Lines 789 816 +27
============================================
+ Hits 475 490 +15
- Misses 314 326 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
704fb46 to
2a229a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds compatibility for Symfony 7 and phpBB 4 by refactoring the page loader routing system. The implementation uses reflection to detect the Symfony version at runtime and delegates to version-specific adapters, ensuring the extension works across Symfony 3-7 and phpBB 3-4.
Changes:
- Extracted core routing logic into a reusable
page_loader_coreclass - Created version-specific adapters (
page_loader_phpbb3andpage_loader_phpbb4) with appropriate type hints for their respective PHP/Symfony versions - Implemented runtime version detection in
page_loader.phpusing reflection to determine which adapter to use
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| routing/page_loader_core.php | New file containing extracted core logic for loading routes from the database |
| routing/page_loader_phpbb3.php | New adapter for phpBB 3 / Symfony 3-6 with legacy-compatible type hints |
| routing/page_loader_phpbb4.php | New adapter for phpBB 4 / Symfony 7 with strict type declarations and modern PHP syntax |
| routing/page_loader.php | Refactored to use reflection-based version detection and delegate to appropriate adapter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.