Avoid closing libxml output encoder twice - #23678
Merged
shivammathur merged 1 commit intoSep 13, 2026
Merged
Conversation
Member
|
looks good but can you target PHP-8.4 instead pls ? |
shivammathur
force-pushed
the
fix/libxml-output-encoder-double-free
branch
from
September 13, 2026 17:06
521ae7b to
92f4705
Compare
Member
Author
|
@devnexen Done |
devnexen
approved these changes
Sep 13, 2026
shivammathur
added a commit
to shivammathur/php-src
that referenced
this pull request
Sep 13, 2026
* PHP-8.5: Avoid closing libxml output encoder twice (php#23678)
pull Bot
pushed a commit
to edisplay/php-src
that referenced
this pull request
Sep 13, 2026
* PHP-8.4: Avoid closing libxml output encoder twice (php#23678)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a double free when PHP and libxml2 2.14.4+ both close the output encoding handler after opening the output fails.
Ref: GNOME/libxml2@fcb7a77