streams: apply so_linger, so_rcvbuf and so_sndbuf to unix sockets - #23584
Open
devnexen wants to merge 2 commits into
Open
streams: apply so_linger, so_rcvbuf and so_sndbuf to unix sockets#23584devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
The unix and udg transports returned from the AF_UNIX branch before any socket context option was read. The parsing happens before the transport split now and the values are applied through the new php_network_apply_sockvals().
devnexen
added
STF: Streams
CI: Solaris
and removed
Extension: standard
ABI break
labels
devnexen
marked this pull request as ready for review
September 5, 2026 14:32
bukka
reviewed
Sep 13, 2026
bukka
left a comment
bukka
left a comment
Member
There was a problem hiding this comment.
It looks mostly good. Just not sure about so_linger change.
| } | ||
|
|
||
| #ifdef SO_LINGER | ||
| if ((PHP_STREAM_XPORT_IS_TCP(stream) || PHP_STREAM_XPORT_IS_UNIX_ST(stream)) |
Member
There was a problem hiding this comment.
Why is so_linger enabled for unix socket? AFAIK it has no effect there.
Member
Author
There was a problem hiding this comment.
No, you are right that was a mistake..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unix and udg transports returned from the AF_UNIX branch before any socket context option was read. The parsing happens before the transport split now and the values are applied through the new php_network_apply_sockvals().