Skip to content

Fix typo: rename InvalidReverseSoldius to InvalidReverseSolidus in Uri\WhatWg\UrlValidationErrorType #22217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
OracleNep wants to merge 3 commits into
base: master
Choose a base branch
from
+26 −9
Draft

Fix typo: rename InvalidReverseSoldius to InvalidReverseSolidus in Uri\WhatWg\UrlValidationErrorType #22217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75f7a0b
Fix typo: rename InvalidReverseSoldius to InvalidReverseSolidus in Ur…
OracleNep Jun 3, 2026
ab8cdcf
Fix generated Uri arginfo spelling
OracleNep Jun 3, 2026
d4e1557
Update generated URI headers
OracleNep Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/uri/php_uri.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ enum UrlValidationErrorType
case InvalidUrlUnit;
case SpecialSchemeMissingFollowingSolidus;
case MissingSchemeNonRelativeUrl;
case InvalidReverseSoldius;
case InvalidReverseSolidus;
case InvalidCredentials;
case HostMissing;
case PortOutOfRange;
Expand Down
4 changes: 2 additions & 2 deletions ext/uri/php_uri_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions ext/uri/php_uri_decl.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions ext/uri/tests/invalid_reverse_solidus_enum.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
--TEST--
Uri\WhatWg\UrlValidationErrorType uses the correct InvalidReverseSolidus spelling
--EXTENSIONS--
uri
--FILE--
<?php
$caseNames = array_map(
static fn($case) => $case->name,
Uri\WhatWg\UrlValidationErrorType::cases(),
);

var_dump(in_array('InvalidReverseSolidus', $caseNames, true));
var_dump(in_array('InvalidReverseSoldius', $caseNames, true));
?>
--EXPECT--
bool(true)
bool(false)
2 changes: 1 addition & 1 deletion ext/uri/uri_parser_whatwg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ static const char *fill_errors(zval *errors)
ZVAL_TRUE(&failure);
break;
case LXB_URL_ERROR_TYPE_INVALID_REVERSE_SOLIDUS:
error_str = "InvalidReverseSoldius";
error_str = "InvalidReverseSolidus";
ZVAL_FALSE(&failure);
break;
case LXB_URL_ERROR_TYPE_INVALID_CREDENTIALS:
Expand Down
Loading