Fix memory leaks in mailparse_uudecode_all#67
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #72, reopened from the fork (iliaal/pecl-mail-mailparse). Branch should not have been pushed to php/ directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mailparse_uudecode_all()leaks in two cases:beginline never releases the initial temp-file pathzend_string(allocated up front, released only inside the first-beginbranch). Any non-uuencoded stream triggers it.itemarray zval is never inserted into the result nor freed.Fix
Track the initial path in its own variable and NULL it once released, then release it at the tail if no
beginline was seen. Give the per-part stream its ownpartpathvariable so the initial path is never clobbered. Free theitemon the temp-file-failure branch, and discard the partial result array if abeginwas seen but every part failed.