Run Linux PHP CLI on a native thread with Go signals blocked - #2647
Draft
henderkes wants to merge 2 commits into
Draft
Run Linux PHP CLI on a native thread with Go signals blocked#2647henderkes wants to merge 2 commits into
henderkes wants to merge 2 commits into
Conversation
Build FrankenPHP as a Go archive hosted by C. Invoke Go's initializer with the original arguments for musl compatibility, retain Go extension setup, and execute PHP CLI on the original thread while Go threads block CLI signals. Preserve the Caddy server entry point in the same executable. Wire the native launcher into Linux Docker, static and xcaddy builds. Cover external signals, Go callbacks, CLI arguments and exit codes, embedded scripts, and graceful server shutdown in regression tests.
Contributor
Author
|
Oh god, this is even worse than I imagined. Perhaps it's worth reaching upstream to go and PR a build tag that disables unmasking? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build FrankenPHP as a Go archive hosted by C. Invoke Go's initializer with the original arguments for musl compatibility, retain Go extension setup, and execute PHP CLI on the original thread while Go threads block CLI signals. Preserve the Caddy server entry point in the same executable.
Wire the native launcher into Linux Docker, static and xcaddy builds. Cover external signals, Go callbacks, CLI arguments and exit codes, embedded scripts, and graceful server shutdown in regression tests.