Conversation
|
php debian trixie just got merged docker-library/php#1596 |
205c16e to
9bc661e
Compare
|
Looks like there isn't a |
Should be available soon |
|
I wanted to wait for golang new image indeed. Let's wait for docker-library/official-images#19675 to be merged and I'll attempt a new build |
9bc661e to
3076509
Compare
|
Looks good, but is there actually a strong reason to use Debian over Ubuntu or vice versa? In a Docker container, I mean. |
|
Debian is more stable than Ubuntu (who's based on the unstable branch of Debian). Also, official PHP images use Debian, so it seems better to stick with it. |
AlliBalliBaba
left a comment
There was a problem hiding this comment.
Main benefit of debian is that some issues are already fixed upstream (and install-php-extensions).
|
Built and tested the trixie image. Working good for me 👍 Just like bookworm |
|
We can merge this whenever you're ready @dunglas . Something to keep in mind is that the new default will be |
|
Thanks for working on this! I don't plan to release a new major of FrankenPHP yet. "Official" PHP images also change the default Debian version when a new version is released, so it looks ok to me as long as we are on sync with official images. Regarding the other change, isn't an upgrade path possible? |
|
The other change is just for library users, since I intend to remove 'NewRequestWithContext' (nothing wild). I recently also tried the |
|
The only "upgrade path" for users would be to specify what OS their containers are based on if it matters for .deb packages. Anything a user would compile/download themselves wouldn't run into issues, given that Trixie uses a newer glibc version. |
|
If I can add something as topic observer - it will be really nice to have FrankenPHP based on Trixie Our example: Trixie image provides postgresql-client for v17, so we do not need to add external repo and then install from it. The same applies to few other packages |
|
We testing it since 1 week. Works good . ✅ we found no issues.
Yes! trixie is very useful because it have some new packages directly in repos. like valkey-server @dunglas When this can be merged ? Do we miss something ? Thanks all |
|
CI failures are just the random failure I have fixed again by moving the test back in #1814 |
|
Thanks!! |
* ci: add support for Debian Trixie * nit * add Trixie to bug_report.yaml --------- Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Fix #1770
Related to docker-library/php#1596, will also require Golang Trixie image when available