Allow to save fallback translations to default locale#515
Open
n3o77 wants to merge 1 commit intophp-translation:masterfrom
Open
Allow to save fallback translations to default locale#515n3o77 wants to merge 1 commit intophp-translation:masterfrom
n3o77 wants to merge 1 commit intophp-translation:masterfrom
Conversation
Member
|
Interesting idea, I'm not against if it helps someone... but tests are completely broken so I can't be sure if that related to this PR or no. Do you want to give a try to fix them? |
Contributor
Author
|
I wasn't sure if the test failures are related to this PR or not either, at first glance i didn't think so. I'm quite busy atm so probably won't have time for a few weeks / months to take a closer look at the tests. If you don't mind keeping the PR open i'll try to squeeze it in at some point. |
Member
|
Sure, help on tests here would be much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the symfony profiler: If a fallback is used it's not possible to save the change to the default locale. Currently editing the fallback leads to an update of the fallback. I've added a second button to allow both cases.