Repository navigation
feat: add a --quiet option to the get command - #132
Merged
Merged
Conversation
When --quiet (-q) is passed and there is no software to download (empty or absent config, no CLI arguments), get now exits with status 0 and no output instead of throwing "No software to download.". An explicitly named but missing config file is still an error, as is any real download. Adds the first command-level test for the get command.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
test(get): run the command through ApplicationTester docs: document --quiet in the get options table Symfony Console already defines --quiet|-q for every command, so the duplicate declaration only survived because the definitions happened to match, and its help text never showed. CommandTester skips Application::configureIO(), so the tests could not see the global flag. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
roxblnfk
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
dload getnow has a-q/--quietoption. When it's set and there's nothing to download — no actions in the config and no software named on the command line — the command exits with status 0 and prints nothing.--quiet, that same situation is still an error (No software to download.), so existing behavior doesn't change unless you opt in.--config=missing.xml) is still an error,--quietor not. Only the "nothing to do" case is softened.Why?
This makes DLoad easier to wire into automated setups that may or may not have anything to download. Today
dload getfails loudly when there's no work, which forces callers to check first or swallow the error themselves. With--quietthey can just run it and let it succeed silently. Closes #127.Checklist
get, covering the quiet success, the default error, and the missing-config guardReview notes
CommandTesterharness doesn't catch exceptions, so the error cases assert viaExpect::exceptionrather than an exit code.