fix(client): card hover preview flicker with follow-cursor and delay#4407
fix(client): card hover preview flicker with follow-cursor and delay#4407kiannidev wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the uiStore to prevent the card preview from being cleared when the cursor is still over a card tile (using [data-card-hover]) during a spurious mouseleave event. A corresponding unit test has been added to verify this behavior. The review feedback recommends using Vitest's fake timers instead of a real setTimeout in the test to avoid potential flakiness in CI environments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Maintainer sweep note: DEFER-FE. This PR touches frontend/client/UI surface, so I am leaving it for Matt's direct frontend handling under the sweep policy. No approval, label, enqueue, or merge from this automated maintainer sweep. |
1c981cc to
01e237f
Compare
|
Maintainer sweep update: current head still touches frontend/client/UI surface, so this remains DEFER-FE for Matt's direct frontend handling. No approval, label, enqueue, or merge from this automated maintainer sweep. |
01e237f to
e07fe3a
Compare
Suppress deferred preview clears while the cursor remains over a [data-card-hover] tile, fixing spurious mouseleave from layout shifts (fixes phase-rs#4377). Model: Composer Co-authored-by: Cursor <cursoragent@cursor.com>
Replace real setTimeout in uiStore test with vi.useFakeTimers per review to avoid flaky CI timing. Co-authored-by: Cursor <cursoragent@cursor.com>
e07fe3a to
2a61f33
Compare
|
Maintainer sweep update: current head |
|
@kiannidev please show a recording illustrating that the issue has been reoslved |
20260630_221334.mp4 |
|
@matthewevans - I uploaded video to show how it is working |
# Conflicts: # client/src/stores/__tests__/uiStore.test.ts
|
Deferred by maintainer intake policy — not ignored. This current head ( A maintainer must explicitly take this PR or add a local frontend-review exception before it can receive substantive review. The defer label is a routing marker only, not a verdict on the change. |
Co-authored-by: kiannidev <156195510+kiannidev@users.noreply.github.com>
|
Deferred by maintainer intake policy — not ignored. This current head ( A maintainer must explicitly take this PR or add a local frontend-review exception before it can receive substantive review. The defer label is a routing marker only, not a verdict on the change. |
|
Superseded by #6239. Current I merged current |
Summary
inspectObject(null)clear fires, keep the preview open if the cursor is still over a[data-card-hover]elementFixes #4377
Test plan
Model: Composer
Made with Cursor