Skip to content

Make some tests more robust #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillep merged 2 commits into from
May 27, 2026
Merged

Make some tests more robust #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
205ea42
Move DebugInfo methods to Pharo
guillep May 27, 2026
c226013
Fix tests using new stepping semantics
guillep May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Sindarin-Tests/SindarinDebuggerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,8 +1106,9 @@ SindarinDebuggerTest >> testMoveToNodeWhenNodeIsInIfTrueIfFalseBlock [

self assert: (sdbg readVariableNamed: #a) equals: 3.

sdbg stepOver.
"When you perform a stepOver, you quit the block and continue just after the ifTrue: message"
sdbg stepOver.
sdbg stepOver.
self assert: (sdbg readVariableNamed: #a) equals: 4
]

Expand Down Expand Up @@ -1407,9 +1408,8 @@ SindarinDebuggerTest >> testSkipCannotSkipReturnIfItIsTheLastReturn [
"we step until we arrive on the method node in `SindarinDebuggerTest>>#methodWithSeveralReturns`, which is mapped to the implicit return bycode."
scdbg step.
nodeWithImplicitReturn := scdbg methodNode.
3 timesRepeat: [ scdbg step ].

self assert: scdbg node identicalTo: nodeWithImplicitReturn.
[scdbg node == nodeWithImplicitReturn]
whileFalse: [ scdbg step ].
self assert: scdbg instructionStream willReturn.

"We skip the return node"
Expand Down
63 changes: 0 additions & 63 deletions src/Sindarin/InstructionStream.extension.st
View file
Open in desktop

This file was deleted.

Loading