test: verify default TLS key exchanges across Go versions - #5
Merged
Merged
Conversation
Exercise the real web-environment client with ML-KEM enabled and disabled, and document consuming-application defaults and macOS CA replacement. Validation: make test with the full race suite and lint passes; the new test also compiles and passes with Go 1.26.5. Adversarial review: Claude Code Fable 5.1, max effort. Final verdict: APPROVE FOR COMMIT. Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web-environment client must honor Go TLS defaults and the process GODEBUG settings. Add a real HTTPS handshake regression test for ML-KEM enabled and disabled, and document Go 1.27 CA trust behavior while retaining the Go 1.26 library floor.
Validation: GOWORK=off make test passed, including lint and the package race suite. No runtime dependency changes.