fix(account)!: separate password permission and update coordinated dependencies - #51
Merged
Merged
Conversation
Coordinate ChangeMyPassword with silo-pkg b3760f56ec23 and SILO Server. Pin upstream minio-go 78bfa91607c2 and mcli fa22b40b4eb7, refresh dependency records and embedded assets, and cover the account button and legacy session policies. Signed-off-by: Feng Ruohang <rh@vonng.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
This was referenced Sep 10, 2026
Signed-off-by: Feng Ruohang <rh@vonng.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Change Password button currently follows CreateUser, coupling self-service password changes to privileged user administration. Use
admin:ChangeMyPasswordand the matching silo-pkg session evaluation, with regressions for legacy CreateUser denies, explicit password denies, user-admin grants, and external identity providers.Breaking authorization compatibility: with the matching Server, a saved CreateUser deny no longer locks the caller's password, while an existing ChangeMyPassword deny is now enforced. Add ChangeMyPassword to the same legacy Deny statement before upgrading when the old restriction must hold. The updated built-in
readonlyalso no longer overrides a separate CreateUser grant; saved overrides retain their existing statements. The capability list returned to Console changes, and mixed Server/Console versions can disagree about the button and enforced action. This is a permission-design change independent of the SDK update; policies are not migrated automatically.The changelog explicitly marks this breaking change and links the migration guide, including the before/after matrix, read-only policies, coordinated rollout and rollback limits. Keep both denies during a rollback window if the old combined restriction must hold; an old Server cannot enforce a password-only deny for this endpoint.
Select the merged dependencies from silo-pkg #6 and mcli #41: minio-go
78bfa91607c2, silo-pkg2d8fd3cbbf07, and mclie6a60edf0952. Regenerate embedded frontend assets, README replacement instructions and CREDITS. Embedder checks compare against the selected package version instead of an obsolete hard-coded version; README and the dependency release record agree with the final merged source pins.The first CI audit also exposed the existing knip dependency on smol-toml 1.6.1 (CVE-2026-85730). Update only that lockfile resolution to the patched 1.7.1, verify normal and malformed TOML inputs, and rerun the high-severity audit. The embedded runtime assets are unchanged by this development dependency patch.
Validation:
GOWORK=off go test ./api/... ./pkg/...GOWORK=off bash hack/embedder-compat.shgit diff --checkpasses, with no runtime or dependency changesThe matching Server #175 is required. The existing release gate remains intact: silo-pkg v3.13.4 is recorded as pending, and mcli source must pass the existing main-branch checks before a Console tag can be released. This PR does not create tags or release artifacts. Upstream minio-go #2274 remains open and is absent from the SDK pin.