Skip to content

test(collect): port the replica-identity fixture to pggo #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexshapalov merged 3 commits into from
Oct 12, 2026
Merged

test(collect): port the replica-identity fixture to pggo #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c4e727
test(collect): port the replica-identity fixture to pggo
elkaix Oct 1, 2026
f9f65bd
build: move the toolchain to go1.27.2 for GO-2026-6613 and GO-2026-6617
alexshapalov Oct 12, 2026
8242801
ci: pin golangci-lint v2.14.0, the first release built against go1.27.2
alexshapalov Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
# change the gate out from under a green PR.
- name: golangci-lint
run: |
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.14.0
"$(go env GOPATH)/bin/golangci-lint" run ./...
# A security-positioned tool must scan its own dependency tree.
- name: govulncheck
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/pgrundev/pgbot

go 1.27

toolchain go1.27.1
toolchain go1.27.2

require (
github.com/BurntSushi/toml v1.6.0
Expand Down
8 changes: 4 additions & 4 deletions internal/collect/replident_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import (
"testing"
"time"

"github.com/jackc/pgx/v5"
"github.com/pgrundev/pgbot/internal/collect"
"github.com/pgrundev/pgbot/internal/conn"
"github.com/pgrundev/pgbot/internal/findings"
"github.com/pgrundev/pgbot/internal/model"
"github.com/pgrundev/pggo"
)

// A publication over a table with no primary key is accepted by Postgres and only
Expand All @@ -25,19 +25,19 @@ func TestIntegration_replicaIdentityMissing(t *testing.T) {
ro := dsn(t)
ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
defer cancel()
admin, err := pgx.Connect(ctx, su)
admin, err := pggo.Connect(ctx, su)
if err != nil {
t.Fatalf("admin connect: %v", err)
}
t.Cleanup(func() { admin.Close(context.Background()) })
t.Cleanup(func() { admin.Close() })

cleanup := func() {
_, _ = admin.Exec(context.Background(), `DROP PUBLICATION IF EXISTS pgbot_it_pub`)
_, _ = admin.Exec(context.Background(), `DROP TABLE IF EXISTS public.pgbot_it_nopk`)
}
cleanup()
t.Cleanup(cleanup)
if _, err := admin.Exec(ctx, `
if _, err := admin.SimpleQuery(ctx, `
CREATE TABLE public.pgbot_it_nopk (id bigint, note text);
INSERT INTO public.pgbot_it_nopk VALUES (1, 'a');
CREATE PUBLICATION pgbot_it_pub FOR TABLE public.pgbot_it_nopk`); err != nil {
Expand Down
Loading