fix: truncated function signatures in GRANT statements (#275)

[tianzhou]

Summary

• Function signatures in privilege GRANT statements were truncated to 63 characters due to PostgreSQL's name type (NAMEDATALEN-1) limit
• In UNION ALL queries combining c.relname/t.typname (type name) with function signature text expressions, PostgreSQL resolved the result column to name, silently truncating longer values
• Fix: cast relname and typname to text in the privilege UNION ALL queries (GetPrivilegesForSchema and GetRevokedDefaultPrivilegesForSchema)

Fixes #275

Test plan

• Added dump test issue_275_truncated_function_grants with a function whose signature exceeds 63 characters
• Test verifies full function signature preserved in both comment header and GRANT statement
• All existing privilege tests pass (grant_function_execute, revoke_public_function, etc.)
• Full test suite passes

Run the new test:

go test -v ./cmd/dump -run TestDumpCommand_Issue275

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes a bug where function signatures in GRANT EXECUTE statements were truncated to 63 characters due to PostgreSQL's name type limit. The issue occurred in UNION ALL queries where name-typed columns (c.relname, t.typname) were combined with text expressions (function signatures), causing PostgreSQL to resolve the result column type to name and silently truncate longer values.

Changes:

• Fixed GetPrivilegesForSchema and GetRevokedDefaultPrivilegesForSchema SQL queries by casting c.relname and t.typname to text in UNION ALL queries
• Added comprehensive integration test case with a function signature exceeding 63 characters to verify the fix
• Added Claude Code workflow documentation for bug fixing and refactoring

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ir/queries/queries.sql	Cast c.relname and t.typname to text type in privilege UNION ALL queries to prevent truncation
ir/queries/queries.sql.go	Regenerated Go code with updated SQL queries containing the type casts
testdata/dump/issue_275_truncated_function_grants/raw.sql	Test input SQL with function having 90-character signature
testdata/dump/issue_275_truncated_function_grants/pgschema.sql	Expected output verifying full signature preservation
testdata/dump/issue_275_truncated_function_grants/pgdump.sql	PostgreSQL pg_dump baseline for comparison
testdata/dump/issue_275_truncated_function_grants/manifest.json	Test case metadata and documentation
cmd/dump/dump_integration_test.go	Test registration for the new test case
.claude/skills/refactor-pass/SKILL.md	Claude Code workflow documentation for refactoring
.claude/skills/fix_bug/SKILL.md	Claude Code workflow documentation for bug fixing

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.