Support PostgreSQL 14-18, add regression suite and CI - #7
Merged
Conversation
- Require PostgreSQL 14+; drop the pre-13 planner-hook compatibility macros and the unreachable _PG_fini callback - Reserve the plan_filter. GUC prefix (MarkGUCPrefixReserved on 15+) so a misspelled setting errors instead of silently disabling the filter - Use PG_MODULE_MAGIC_EXT with a module name and version on 18+ - Replace the manual testlimit.sql with a pg_regress suite wired up as make installcheck; assertions are behavioral and the expected output is version-independent, so one file serves all supported majors - Add GitHub Actions CI: build with -Werror and run installcheck against PostgreSQL 14-18 pgdg packages, cppcheck static analysis, and a report-only pgbench benchmark with results kept as artifacts - Fix README documentation of filter_select_only (was documented under a nonexistent name); document supported versions and testing - Record the decisions as ADRs 0001-0003; add ARCHITECTURE.md
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the module from its last compatibility target (PostgreSQL 13) up to the full set of upstream-supported majors, and adds a CI pipeline.
Code (
plan_filter.c)#errorbelow that); the pre-13 planner-hook compatibility macros are gone since the 13+ hook signature is universal in the supported window_PG_finiremoved — PostgreSQL 15 removed library unloading, and it was unreachable before thatplan_filter.GUC prefix is reserved (MarkGUCPrefixReservedon 15+,EmitWarningsOnPlaceholderson 14), so a misspelled setting now errors instead of silently leaving the filter offPG_MODULE_MAGIC_EXTwith module name/version on 18+, plain magic earlierTests
testlimit.sql(100M-row table, no pass/fail) is replaced by a pg_regress suite run viamake installcheckSET LOCALescape hatch and its expiry,filter_select_onlyboth ways, and SUSET enforcement of both GUCsLOAD, so it also passes against clusters that preload the module with a limit configuredCI (
.github/workflows/ci.yml)-Werror+installcheckon PostgreSQL 14, 15, 16, 17, and 18 (pgdg packages, self-owned throwaway cluster per job); cppcheck static analysiscontinue-on-errorbecause shared-runner numbers are too noisy to gate onGITHUB_TOKENrestricted tocontents: readDocs
filter_select_onlybeing documented under a nonexistent name (limit_select_only), documented the supported-version policy and testing, removed pre-9.2 material, added the CI badgedocs/adr/(support window, test design, CI design) and a newARCHITECTURE.mdTesting
installcheckpasses on PostgreSQL 14-18 in anubuntu:24.04rehearsal of the exact CI steps — each version tested against both a pristine cluster and one preconfigured withsession_preload_librariesand a cost limit — and on PostgreSQL 18.3 on macOS