chore: parameterize bare list/tuple generics; enforce disallow_any_generics - #6
Merged
Conversation
…nerics T1: A py.typed package should not leak implicit-Any element types to consumers. Parameterize the three bare generics in engine.py public signatures (format_params, create, _insert_rows) to list[Any] / list[tuple[Any, ...]], and enable mypy's disallow_any_generics so the generics cannot silently regress. Pure annotation change; no runtime effect. Closes T1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P5 typing (closes T1)
A
py.typedpackage should not leak implicit-Anyelement types to consumers.Fix: parameterize the three bare generics in
engine.pypublicsignatures:
Dialect.format_params(params: list)→list[Any]Engine.create(..., rows: list[tuple] | None)→list[tuple[Any, ...]] | NoneEngine._insert_rows(..., rows: list[tuple])→list[tuple[Any, ...]]Pure annotation change; no runtime behavior. The whole package is clean under
mypy --disallow-any-generics, so this PR also enablesdisallow_any_genericsin
[tool.mypy]— barelist/dict/tuplenow fail CI, preventing silentregression. (The predicates
.sql()methods that previously carried barelistreturns were removed in #4.)No new tests — annotation-only. Local gate green:
ruff,mypy(with the newflag),
pytest(113 passed, 15 skipped).