docs: re-validate perf-review I79/I84 against post-rewrite code - #82
Merged
Conversation
Both predate the multi-page freemap + transaction.rs extraction, so their line refs are stale and their fixes are overtaken: - I84 (freemap from-0 scan, no cursor): ADDRESSED — FreeMapTree::allocate_first now scans from a hint cursor (freemap_tree.rs:470), threaded via cow_alloc. Marked resolved. - I79 (clone-not-swap at commit): re-scoped. The 8 KB freemap-bitmap clone is gone (freemap is a COW tree now); the surviving current_live_slots clone in SlotPacker::commit is NOT a free swap — current_live_slots is read post-commit by stats (sparse_data_pages / data_page_ids_snapshot), so a swap needs a read-timing safety proof + test, and it sits below the fsync floor. Not a no-bench win.
🚦 Bench results: PR vs main
Per-scenario detail (4 metrics × cells)document-store
mutation-log
ycsb-a
ycsb-b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-validates two 2026-06-01 perf-review items against the current code (both predate the multi-page freemap rewrite and the
transaction.rsextraction, so their line refs were stale).allocate_firstscans from byte 0, no cursor) → ✅ ADDRESSED. The COW tree'sFreeMapTree::allocate_first(freemap_tree.rs:470) now scans from ahintcursor and advances it per allocation — exactly what the finding asked for. Closed.current_live_slotsclone inSlotPacker::commitis read post-commit bysparse_data_pages/data_page_ids_snapshot, so amem::swapwould expose pre-transaction state and needs a read-timing proof + regression test — and it's a microsecondHashMapclone below the fsync floor. Not a no-bench win.Outcome of the requested re-validation: no cheap confirmed code wins here — one finding was already fixed by the freemap rewrite, the other isn't cheap in the current code. Tracker corrected so neither gets re-triggered.
Docs-only.