docs: record transaction.rs decomposition status — StagingTxn deferred (I141) - #80
Merged
Merged
Conversation
…ion deferred (I141) The 2026-06-22 review's god-module SMELL was worked through four unit extractions (SlotPacker #77, FreemapRecycle #78, CommitProtocol #79, FaultInjector #76); the final StagingTxn extraction is deliberately deferred. The candidate-prepare/install staging vocabulary is shared across allocate_inner (staging.rs) and update_inner/delete_inner (mutate.rs), so a context-based extraction cannot be contained to staging.rs without dragging the delicate mutation paths through a mechanical wrapper change. Recorded as future work to be done incrementally if/when those paths are touched, not re-triggered from the SMELL alone.
🚦 Bench results: PR vs main✅ No regressions detected
Per-scenario detail (4 metrics × cells)document-store
mutation-log
ycsb-a
ycsb-b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the disposition of the 2026-06-22 review's
transaction.rsgod-module finding (SMELL) as ISSUES.md I141.The decomposition was worked through four behavior-preserving unit extractions —
SlotPacker(#77),FreemapRecycle(#78),CommitProtocol(#79),FaultInjector(#76) — and then deliberately stopped. The planned finalStagingTxnextraction is deferred: the candidate-prepare/install staging vocabulary (handle_table_insert_candidate,membership_*_candidate,abort_allocate_prepare,inject_membership_failure,insert_into_data_page) is shared acrossallocate_inner(staging.rs) andupdate_inner/delete_inner(mutate.rs), so a context-based extraction can't be contained tostaging.rswithout dragging the most delicate mutation paths + packing through a mechanical wrapper change for little cohesion gain.staging.rsis already a focused concern file.Future work: fold the shared vocabulary into a
StagingTxnunit incrementally if/when those paths are touched for a real reason — not re-triggered from the SMELL alone.Docs-only; no code change.