Fix opcode value parsing bugs. - #24
Merged
Merged
Conversation
pfusik
reviewed
Sep 25, 2026
| when the listing goes to `-`, nor overwrites the listing file when both | ||
| */l* and */t* name the same file (by Adrian Matoga) | ||
| - fixed parsing of opcode values: an operand such as in `{jsr $1234}` | ||
| is no longer misread, and a line ending with `{lda <` no longer crashes |
Owner
There was a problem hiding this comment.
What do you mean "misread" ? Did readChar() consume the space then readAddrMode() expected that space?
Contributor
Author
There was a problem hiding this comment.
Yup. Failed with "Space expected".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.