Make catch generic to improve call site ergonomics#701
Merged
peterstace merged 2 commits intomasterfrom Feb 13, 2026
Merged
Conversation
Previously, callers that needed a result from catch had to declare a variable before the call and assign to it inside the closure via capture. By making catch a generic function returning (T, error), callers can now return values directly from the closure and use `return catch(...)` without the intermediate variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, callers that needed a result from catch had to declare a variable before the call and assign to it inside the closure via capture. By making catch a generic function returning (T, error), callers can now return values directly from the closure and use
return catch(...)without the intermediate variable.Check List
Have you:
Added unit tests? N/A
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) N/A
Updated the README.md (if new functionality is added?) N/A
Related Issue