Remove Kubernetes/Docker dead code from config and server#7
Merged
persimmon16 merged 1 commit intofeat/apple-containerfrom Apr 1, 2026
Merged
Conversation
Remove sandbox_namespace, sandbox_image_pull_policy, client_tls_secret_name, and host_gateway_ip from Config and server CLI args. These were Kubernetes- specific fields unused in the Apple Container backend. Replace the Kubernetes DNS fallback in resolve_sandbox_exec_target with an error — the sandbox backend must resolve exec targets directly. Default sandbox_backend changed from "kubernetes" to "apple-container".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox_namespace,sandbox_image_pull_policy,client_tls_secret_name,host_gateway_ipfields fromConfigand their CLI args, builder methods, and default functionsresolve_sandbox_exec_targetwith explicit errorsandbox_backendtoapple-containerNote: CLI dead code (
doctor execsubcommand,KubeEventReason) tracked separately — requires subcommand removal.Test plan
cargo check -p openshell-server -p openshell-corepasses