[FEATURE] Logstable: Add back in colour coded log rows #512
+85
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fraser-qs <fraser@quantum-secret.com>
fraser-qs
force-pushed
the
feature/colour_coded_log_border
branch
from
8ee0062 to
5af380a
Compare
Signed-off-by: fraser-qs <fraser@quantum-secret.com>
Signed-off-by: fraser-qs <fraser@quantum-secret.com>
jgbernalp
reviewed
Jan 2, 2026
logstable/src/components/utils.ts
Outdated
Comment on lines
20
to
21
| if (level.includes('critical')) return 'error'; | ||
| if (level.includes('fatal')) return 'error'; |
Contributor
There was a problem hiding this comment.
These two probably should have its own color, usually purple. To denote a more severe case than an error. A more complete mapping can include the following values:
export const severityAbbreviations: Record<Severity, Array<string>> = {
critical: ['critical', 'emerg', 'fatal', 'alert', 'crit'],
error: ['error', 'err', 'eror'],
debug: ['debug', 'dbug'],
info: ['info', 'inf', 'information', 'notice'],
trace: ['trace'],
warning: ['warn', 'warning'],
unknown: ['unknown'],
other: [''],
};
Author
There was a problem hiding this comment.
I have updated to set a different colour for these other messages, and made use of the pattern you have provided above.
Signed-off-by: fraser-qs <fraser@quantum-secret.com>
jgbernalp
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds back in the colour coded borders that were present before PR392.
adds in support for missing 'critical' and 'fatal' severities
Existing:
Changes:
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes