Skip to content

Conversation

@shahrokni
Copy link
Contributor

@shahrokni shahrokni commented Dec 30, 2025

Relates to: perses/perses#3483

Description 🖊️

This change adds a link editor to the table column setting editor.

image

⚠️ Schema validation should be done from the Shared Package. So, here you can not find it

Test 🧪

You should be able to add, edit, apply and finally persist the link setting.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@shahrokni shahrokni force-pushed the feat/add_table_link_editor branch from a636307 to 1b49437 Compare December 30, 2025 13:47
@shahrokni shahrokni marked this pull request as ready for review December 30, 2025 13:49
@Nexucis Nexucis requested review from a team and jgbernalp and removed request for a team December 30, 2025 13:51
Copy link
Contributor

@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still more in favor of having the new Link form inline rather than in a modal, but I'm fine with the MVP in this state.

@shahrokni
Copy link
Contributor Author

shahrokni commented Dec 30, 2025

Still more in favor of having the new Link form inline rather than in a modal, but I'm fine with the MVP in this state.

After a developing a quick prototype, we decided to go with the inline option.
I Will work on it again. Tnx for the valuable insight.

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the feat/add_table_link_editor branch from 1b49437 to 8389673 Compare January 5, 2026 14:43
@shahrokni shahrokni requested a review from a team as a code owner January 5, 2026 14:43
@shahrokni shahrokni added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit 81a57bc Jan 5, 2026
12 checks passed
@shahrokni shahrokni deleted the feat/add_table_link_editor branch January 5, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants